bug: adds validation for siteid #349 #350
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kurtkanaskie
requested changes
Dec 4, 2023
There was a problem hiding this comment.
In cmd/apidocs/apidocs.go why doesn't this line make siteid required:
_ = Cmd.MarkFlagRequired("siteid")
And why is siteid a global on list?
gorun apidocs list --help
Returns the catalog items associated with a portal
Usage:
apigeecli apidocs list [flags]
Flags:
-h, --help help for list
Global Flags:
-a, --account string Path Service Account private key in JSON
--default-token Use Google default application credentials access token
--disable-check Disable check for newer versions
--metadata-token Metadata OAuth2 access token
--no-output Disable printing all statements to stdout
-o, --org string Apigee organization name
--print-output Control printing of info log statements (default true)
-s, --siteid string Name or siteid of the portal
-t, --token string Google OAuth Token
vs here, it's not in global
gorun apidocs --help
Manage Apigee API catalog item through ApiDoc
Usage:
apigeecli apidocs [command]
Available Commands:
create Create a new catalog item
delete Deletes a catalog item
documentation Manage the documentation for the specified catalog item
get Gets a catalog item
list Returns the catalog items associated with a portal
update Update an existing catalog item
Flags:
-h, --help help for apidocs
-o, --org string Apigee organization name
-s, --siteid string Name or siteid of the portal
Global Flags:
-a, --account string Path Service Account private key in JSON
--default-token Use Google default application credentials access token
--disable-check Disable check for newer versions
--metadata-token Metadata OAuth2 access token
--no-output Disable printing all statements to stdout
--print-output Control printing of info log statements (default true)
-t, --token string Google OAuth Token
|
Regarding, I don't know. I expected it to be which is why I didn't have the validation. Turns out the field is not mandatory and I got errors. Regarding |
kurtkanaskie
approved these changes
Dec 11, 2023
|
LGTM, I understand it's how the library works. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.